-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cases to optimize linq #1157
base: main
Are you sure you want to change the base?
More cases to optimize linq #1157
Conversation
@jamesHargreaves12 MinBy/MaxBy throws exception in case of no elements so it should be First not FirstOrDefault. |
@@ -199,6 +213,48 @@ public static void AnalyzeWhere(SyntaxNodeAnalysisContext context, in SimpleMemb | |||
Report(context, invocation, span, checkDirectives: true, properties: properties); | |||
} | |||
|
|||
private static bool IsNet6OrGreater(Compilation compilation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not maintainable as .NET version will grow.
I suggest to check if the MinBy
method is contained in Enumerable
class, for example:
enumerableSymbol.FindMember<IMethodSymbol>("MinBy") is not null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree thats much better :)
@@ -184,6 +184,7 @@ private static void AnalyzeInvocationExpression(SyntaxNodeAnalysisContext contex | |||
{ | |||
OptimizeLinqMethodCallAnalysis.AnalyzeWhere(context, invocationInfo); | |||
OptimizeLinqMethodCallAnalysis.AnalyzeFirstOrDefault(context, invocationInfo); | |||
OptimizeLinqMethodCallAnalysis.AnalyzerOrderByAndFirstOrDefault(context, invocationInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to First
case.
I don't think MaxBy does throw in the case of an empty List: |
Ok, it does not throw always when the sequence is empty but sometimes it does: https://source.dot.net/#System.Linq/System/Linq/Max.cs,442 /// <para>If <typeparamref name="TKey" /> is a reference type and the source sequence is empty or contains only values that are <see langword="null" />, this method returns <see langword="null" />.</para> |
I have messed about with this some more and the Csharp docs are wrong it should be TSource instead of TKey which is checked for reference type. |
You are right that the doc is wrong, but the bottom line is that MaxBy throws sometimes which must be taken into account when applying these LINQ optimizations. |
@jamesHargreaves12 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Adds support for the following transformations:
Do not restrict Applying Demorgans laws to the cases when the inside of the All / Any invocation is of the form !(...) - We can invert any boolean expression using SyntaxLogicalInverter.